Re: It works... now what?

//
cmp eax,ERROR_SUCCESS
je cont//

This can be replaced by
or eax eax | je ***

While not important, it will save a byte.

replacing:

//mov esi src
cmp BYTE PTR [esi],48 //

with :
cmp b$src 48
He saves 5 bytes

Still not important or anything, I just noticed, since you were
conserned with "tidyness"


Also since the only diffrence between on and off is the setting of ARG
to 1 or 0 he could do:

mov d$ARG eax
cmp b$src 48 | jne Onoff
inc b$ARG 1

OnOff:
invoke RegSetValueEx,lpFullKey,addr lpValueName2,NULL,
00000004h,addr arg,4
invoke RegSetValueEx,lpFullKey,addr lpValueName,
NULL,00000001h,offset ProxyAddr,32


done:

saving a heap of bytes.


Anyway, Thanks for trying, Hutch.

.