Re: Access violation in free()

Richard Heathfield wrote:
Martin Ambuhl said:

<snip>
Try the following and see if you have better luck:
<snip>

char *CopyString(char *s)

Better: char *CopyString(const char *s)

{
int length = strlen(s);

Better: size_t length = strlen(s);

I consider this better:

assert(NULL != s);

before calling strlen().

char *t = malloc(length+1); /* note! */
strcpy(t, s); /* in your original code, this violated the bounds
of
the array pointed to by t, corrupting memory. */

Better: before copying to the newly created buffer, ensure it exists:

if(t != NULL)
{
strcpy(t, s);
}

or even:
if(t != NULL)
{
memcpy(t, s, length + 1);
}

Unless you are writing e.g. a non-stop server (or a library for it, kernel mode code etc.), the normally best thing to do on memory failures, is simply to exit.

Propagating NULL all over the place, result in bloated and hard-to-read code.

--
Tor <torust [at] online [dot] no>
.