Re: Malcolm's new book - Chapter 1 review

Kelsey Bjarnason <kbjarnason@xxxxxxxxx> writes:

[snips]
inF>
On Wed, 29 Aug 2007 19:24:19 +0100, Malcolm McLean wrote:

In practise fgets() is too hard for the average programmer to use correctly,
as has time after time been demonstrated here. I caused outrage by
suggesting that most programs would be safer if they replaced fgets() with
gets(). However I was right.

The only one here I can recall ever claiming to use gets safely was (from
memory) Dann Pop. However, that was (again, from memory) in a rather
limited set of circumstances.

The use of gets is *never* warranted except, possibly, in very rare cases
where you absolutely control all possible inputs, as without that, the
function simply cannot be used safely.
It is a function to be used only by experts, and only in very unusual
cases; I can't see any way you could have recommended it and not been
simply wrong.

Would I recommend it? Not really/necessarily, but a lot code is written where
the input limits are set by the run time setup. It seems to be favorite
icon for people wanting to demonstrate their knowledge of buffer over runs.


The real answer is not to use gets() but something like ggets()

Which, presumably, can be used safely. Or just learn how to use
fgets.

ggets() is a mess. It does nothing particularly well - its increment is
poorly thought out, is non configurable and has no idea of how to bail
out. It is a far better idea to use fgets() and do it properly.
.

Relevant Pages

  • Re: Malcolms new book - Chapter 1 review
    ... suggesting that most programs would be safer if they replaced fgets() with ... limited set of circumstances. ... Would I recommend it? ... the input limits are set by the run time setup. ...
    (comp.lang.c)
  • Re: writing strings instead of rabish to file using fprintf
    ... > please and help me finding the reason why this rabish is being ... clrscr() is non-standard. ... amateurs to avoid it and use fgets() plus any of (sscanf, strtod, ... I also recommend fflush; after all the printfs. ...
    (comp.lang.c)