Re: Source Control



TObject wrote:

> And what kind of errors can be caught, by spending only
> seconds to review a couple of hours or more of work?

Do you sometimes comment out a piece of code to see if that's the cause
of a problem? Ever forgot to enable it back after you found the problem?

Have you ever added debug messages in the code? And forgot to remove
them?

How about accidently pressing something in the keyboard, adding a
random keystroke to the source file? Inside a string?

Those are unintended changes that I caught more than once when
reviewing my changes. With the nice side-effect of having a clean look
at the changes and see if they make sense.

I think I'm good at proofreading things. When diff'ing before checking
in, every once in a while I see something strange I did, causing me to
go back and fix it.

Spend time making a code review before checking in. It often pays out
in saved debugging time later.

--
Leonel
.



Relevant Pages

  • Re: Source Control
    ... TObject wrote: ... > And what kind of errors can be caught, by spending only ... > seconds to review a couple of hours or more of work? ... Prev by Date: ...
    (borland.public.delphi.non-technical)
  • Re: AP Poll: Mccain ties Obama!
    ... Hugh Sullivan)? ... Review what he proposes in new spending and try to get that ... amount in new taxes from the wealthy. ...
    (rec.sport.football.college)
  • Re: Crossrail under way
    ... saying they'll review each and every government spending project as ... But whilst I'm sure they'd do a review of Crossrail, ... By saying "But whilst I'm sure they'd do a review of Crossrail, ...
    (uk.railway)
  • Re: DC Time Lapse Video
    ... end to spending that could help them get a new job. ... people who yawned at the price tag for the Iraq adventure of choice. ... Lots of good cigar info, the ASC Birthday page, FAQs, vendors and more at ... A "great" review is one with the name of the cigar before the review text ...
    (alt.smokers.cigars)
  • Re: Source Control
    ... TObjec wrote ... > And what kind of errors can be caught, by spending only ... > seconds to review a couple of hours or more of work? ... Prev by Date: ...
    (borland.public.delphi.non-technical)