Re: Can use of singletons denote poor project design?


Daniel Parker wrote:
Phlip wrote:
[X-posted to comp.object and followups set]

John Fly wrote:

Right now I use [singletons] for :

Logging server : A central message storage and distribution to N number
of reports/logs)
Program State : Again a central point to keep track of program status.
Central Data representation


Regards,
Daniel Parker

To answer the question in the subject: yes.

Further, to rephrase the quesiton as, "Can use of X denote poor project
design?" where X is any design pattern/documentation/metric/etc., the
answer is probably: yes. Anything can be overused/abused.

To focus, however, on Singletons:

"It is a truth universally acknowledged, that a singleton in possession
of complex behaviour, must be in want of a refactoring."

It is true, furthermore, that all singletons in a project can be
replaced by one, less complex singleton: I tend to have only one
signleton in my code, which is a ConcreteRegistry. During start-up, all
the other bits register themselves in the registry, for example the
Model, View, and Controller interfaces. Then they can all access one
another by:

class ConcreteView implements View {

void doSomething() {
Model model = ConcreteRegistry.getInstance().getModel();
}
}

This tends to lead to the result that a lot of the classes depend on
the singleton, but this is not necessarily a bad thing as the
singleton's behaviour is rigourously limited to storing and serving
interfaces, and the singleton itself is not dependent on the methods of
the interfaces that it stores.

The point is: here's a singleton with loads of dependencies on it, yet
this isn't, I think, bad design. So although the answer to the
subject-line question is yes, the converse is not true: using
singletons does not imply bad design.

..ed

--
www.EdmundKirwan.com - Home of The Fractal Class Composition

.

Relevant Pages

  • Re: Static Classes ... in response to B. Voigts comments
    ... Singleton had any reference to Interfaces or Inheritance. ... no one would ever see the private member except the class implementing it. ...
    (microsoft.public.dotnet.languages.csharp)
  • Re: singleton vs static
    ... > Advantages of Singleton: ... GoF's Design Patterns book says itself that it's not an OO primer, ... during which these interfaces are sucked back out ... It's often appropriate to design a Facade interface as the only way to ...
    (comp.object)
  • Re: Static Classes ... in response to B. Voigts comments
    ... Peter Duniho wrote: "... ... me that one obvious difference between a static class and the singleton ... Singleton had any reference to Interfaces or Inheritance. ... use of a Static class, Program.cs, every time we use the default WinForms ...
    (microsoft.public.dotnet.languages.csharp)
  • Re: Can use of singletons denote poor project design?
    ... Program State: Again a central point to keep track of program status. ... To pass fake data into the modules that use those systems, ... Singleton is "because there's only one of them", ... returns a default date format, which is a singleton object, there is ...
    (comp.object)
  • Re: Can use of singletons denote poor project design?
    ... A central message storage and distribution to N number ... Program State: Again a central point to keep track of program status. ... "It is a truth universally acknowledged, that a singleton in possession ... ConcreteView class above depends on View, Model, and the ...
    (comp.object)