Re: safe to delete elements of array in foreach

ZeldorBlat wrote:
On May 18, 9:05 pm, Jerry Stuckle <jstuck...@xxxxxxxxxxxxx> wrote:
ZeldorBlat wrote:
On May 18, 11:40 am, "Jon Slaughter" <Jon_Slaugh...@xxxxxxxxxxx>
wrote:
"ZeldorBlat" <zeldorb...@xxxxxxxxx> wrote in message
news:1179501018.125313.63600@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
On May 18, 11:05 am, "Jon Slaughter" <Jon_Slaugh...@xxxxxxxxxxx>
wrote:
Is it safe to remove elements from an array that foreach is working on?
(normally this is not the case but not sure in php) If so is there an
efficient way to handle it? (I could add the indexes to a temp array and
delete afterwards if necessary but since I'm actually working in a nested
situation this could get a little messy. I guess I could set there values
to
null and remove them afterwards?
Thanks,
Jon
Why don't you try it and see what happens?
Um... cause I did... but that doesn't mean much. Just cause someone tries
something doesn't prove that it will always work like that...
got any more bright ideas?
Or is the question to hard for you?
No, the question is not to (sic) hard for me. But, as you've already
discovered, it isn't that difficult to test, either.
Sorry, I agree with Jon on this one.

I make it a habit not to delete entries in a foreach() loop. Rather, I
build an array of keys I want to delete, and after the loop ends, delete
the entries from my delete array.

I don't know whether an operation like this is guaranteed to work in PHP
- I've never seen it documented, so I suspect not. And just because it
works in one release under a certain set of conditions is not a
guarantee it will work on another release or under different conditions.

--
==================
Remove the "x" from my email address
Jerry Stuckle
JDS Computer Training Corp.
jstuck...@xxxxxxxxxxxxx
==================

I never said I disagreed with him -- in fact I, too, generally don't
delete elements inside a foreach. However, I will say that when I
have done it things seem to work as expected. I guess it all comes
down to whether or not the array's internal pointer is modified when
you unset the element it's pointing to (I suspect it isn't).

I see a lot of questions in these newsgroups that look something like,
"What happens if I do X?" or "In PHP is this code valid?" The point I
was trying to make (and apparently Jon took offense to it) was that
it's easy enough to just try it and see what happens. Software is
just that: soft. It can be changed easily enough :)



Yes, and in a case like this that change can break his code.

As I said - I've never seen it documented that this is valid. Maybe it is and I missed it; I really don't know.

But this isn't the same as a lot of other "try it and find out" questions. In this case it's a known problem in other programming languages, and if it is documented that this should or should not work, no one has pointed anyone to it.

And until I see something from the PHP developers saying it is OK, I wouldn't do it.

--
==================
Remove the "x" from my email address
Jerry Stuckle
JDS Computer Training Corp.
jstucklex@xxxxxxxxxxxxx
==================
.

Relevant Pages

  • Re: Gallery Pagination Result Problem
    ... Jerry Stuckle ... JDS Computer Training Corp. ... To add to this, I've just noticed that when I load the landscape gallery, not only does it display all images now instead of just the landscape images, but if I click the paginated result for page 2, it changes the page title back to just Gallery, instead of the main page of Landscape gallery. ... I've got PHP and My SQL for Dummies, and PHP and MySQL Web Development. ...
    (comp.lang.php)
  • Re: Script halts after 60 minutes
    ... Checked if php was running in safe mode, ... Does your server have a timeout value specified? ... Jerry Stuckle ... JDS Computer Training Corp. ...
    (comp.lang.php)
  • Re: Script halts after 60 minutes
    ... Checked if php was running in safe mode, ... Does your server have a timeout value specified? ... Jerry Stuckle ... JDS Computer Training Corp. ...
    (comp.lang.php)
  • Re: Commands out of sync error
    ... connection at the top of the php page and then calling multiple stored ... When I call the 2nd stored procedure I'm ... Jerry Stuckle ... JDS Computer Training Corp. ...
    (comp.lang.php)
  • Re: Need help on PHP for MPE/ix
    ... Here is the syntax of the dbupdate intrinsic in PHP: ... assoc array of item values) ... Please let me know if you have any more suggesstions to solve this problem. ... Pavan Kumar Rati wrote: ...
    (comp.sys.hp.mpe)