Re: DBI-1.58 test failure on Windows

Tim Bunce wrote:
On Tue, Jun 26, 2007 at 02:25:05PM +0100, Steve Hay wrote:
Gabor Szabo wrote:
Hi,

both
t\41prof_dump.t
t\zvg_41prof_dump.t
fail on plain ActivePerl 5.8.4 on Windows

[...]
# Failed test (t\41prof_dump.t at line 79)
not ok 14 - Program matches
# got: 't\\41prof_dump.t'
# expected: 't\41prof_dump.t'
Works fine for me (using bleadperl) when I just run "nmake test", but if I explicitly run "perl -Mblib t\41prof_dump.t" then it fails as above.

Running "perl -Mblib t/41prof_dump.t" is fine, though, which explains why "nmake test" works, given also that the Makefile has "TEST_FILES=t/*.t" rather than "TEST_FILES=t\*.t".

Attached patch fixes it, but it's arguably just hiding the real problem of having \\ where only \ was expected.

The bug is that DBI::ProfileDumper is 'escaping' the header strings but
DBI::ProfileData isn't unescaping them.

Please try the attached and let me know if it works for you.
Thanks!

Sorry, it still doesn't work:

not ok 14 - Program matches
# Failed test 'Program matches'
# at t\41prof_dump.t line 79.
# got: 't\\41prof_dump.t'
# expected: 't\41prof_dump.t'

Putting some debug into unescape_key() and escape_key() I see some output from escape_key(), changing the \ to \\, but none from unescape_key(). Are you sure DBI::ProfileData is even involved here?

--
.